On 7/27/23 5:21 AM, Liao, Bard wrote:
On 7/27/2023 10:14 AM, Lu, Brent wrote:
max_98390_components[] and max_98390_4spk_components[] are still used
by sof_rt5682.c, we should remove them in the same patch.
Maybe combine the 2 patches together?
I've got your point but these two patches are doing two things: one is
refactor the
code and add a detection feature, the other one is removing the quirk.
Not sure if
it's proper to merge them.
The point is that if you remove them and they are still used somewhere,
you will break the build. i.e. Kernel will not compile if we apply the
first patch only.
IOW git bisect is broken and that's a big no-no.
