RE: [PATCH v2 1/2] ASoC: Intel: maxim-common: get codec number from ACPI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Subject: RE: [PATCH v2 1/2] ASoC: Intel: maxim-common: get codec number from ACPI
From: "Lu, Brent" <brent.lu@xxxxxxxxx>
Date: Thu, 27 Jul 2023 03:18:31 +0000
Cc: "alsa-devel@xxxxxxxxxxxxxxxx" <alsa-devel@xxxxxxxxxxxxxxxx>, "Rojewski, Cezary" <cezary.rojewski@xxxxxxxxx>, Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>, Liam Girdwood <liam.r.girdwood@xxxxxxxxxxxxxxx>, Peter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx>, Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>, Ranjani Sridharan <ranjani.sridharan@xxxxxxxxxxxxxxx>, Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, "Jaroslav Kysela" <perex@xxxxxxxx>, Takashi Iwai <tiwai@xxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Ajye Huang <ajye_huang@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>, "Zhi, Yong" <yong.zhi@xxxxxxxxx>, Terry Cheong <htcheong@xxxxxxxxxxxx>, "Bhat, Uday M" <uday.m.bhat@xxxxxxxxx>, "Chiang, Mac" <mac.chiang@xxxxxxxxx>, "R, Dharageswari" <dharageswari.r@xxxxxxxxx>, Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>, ye xingchen <ye.xingchen@xxxxxxxxxx>
In-reply-to: <ZMFJf2MM35KBFR95@smile.fi.intel.com>
References: <20230726140848.2267568-1-brent.lu@intel.com> <20230726140848.2267568-2-brent.lu@intel.com> <ZMFJf2MM35KBFR95@smile.fi.intel.com>

> 
> > +		pr_err("invalid codec number %d for %s\n", num_codecs,
> > +			MAX_98390_ACPI_HID);
> 
> I believe you have struct device pointer available, use dev_err().
> 

Fixed in V3 patch. Thanks.

Regards,
Brent

References:
- [PATCH v2 0/2] Intel: sof_rt5682: remove quirk flag
  - From: Brent Lu
- [PATCH v2 1/2] ASoC: Intel: maxim-common: get codec number from ACPI
  - From: Brent Lu
- Re: [PATCH v2 1/2] ASoC: Intel: maxim-common: get codec number from ACPI
  - From: Andy Shevchenko

Prev by Date: [PATCH 2/3] ASoC: fsl_micfil: Add fsl_micfil_check_version function
Next by Date: Re: [PATCH 1/2] ASoC: Intel: maxim-common: get codec number from ACPI
Previous by thread: Re: [PATCH v2 1/2] ASoC: Intel: maxim-common: get codec number from ACPI
Next by thread: [PATCH v2 2/2] ASoC: Intel: sof_rt5682: remove SOF_MAX98390_TWEETER_SPEAKER_PRESENT flag
Index(es):
- Date
- Thread

[Index of Archives] [ALSA User] [Linux Audio Users] [Pulse Audio] [Kernel Archive] [Asterisk PBX] [Photo Sharing] [Linux Sound] [Video 4 Linux] [Gimp] [Yosemite News]