Re: [PATCH 09/11] dt-bindings: arm: msm: kpss-acc: Make the optional reg truly optional

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>, cros-qcom-dts-watchers@xxxxxxxxxxxx, Andy Gross <agross@xxxxxxxxxx>, Bjorn Andersson <andersson@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>, Conor Dooley <conor+dt@xxxxxxxxxx>, Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>, Benjamin Li <benl@xxxxxxxxxxxx>, James Willcox <jwillcox@xxxxxxxxxxxx>, Joseph Gates <jgates@xxxxxxxxxxxx>, Stephan Gerhold <stephan@xxxxxxxxxxx>, Zac Crosby <zac@xxxxxxxxxxxx>, Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>, Banajit Goswami <bgoswami@xxxxxxxxxxx>, Liam Girdwood <lgirdwood@xxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Lee Jones <lee@xxxxxxxxxx>, Stephen Boyd <sboyd@xxxxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Xu Yang <xu.yang_2@xxxxxxx>, Peng Fan <peng.fan@xxxxxxx>, Christian Marangi <ansuelsmth@xxxxxxxxx>, Wesley Cheng <quic_wcheng@xxxxxxxxxxx>, Jun Nie <jun.nie@xxxxxxxxxx>, Max Chen <mchen@xxxxxxxxxxxx>, Shawn Guo <shawn.guo@xxxxxxxxxx>, Vivek Gautam <vivek.gautam@xxxxxxxxxxxxxx>
Subject: Re: [PATCH 09/11] dt-bindings: arm: msm: kpss-acc: Make the optional reg truly optional
From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Date: Mon, 24 Jul 2023 11:05:44 +0200
Cc: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>, linux-arm-msm@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Vincent Knecht <vincent.knecht@xxxxxxxxxx>, "Bryan O'Donoghue" <bryan.odonoghue@xxxxxxxxxx>, Konrad Dybcio <konradybcio@xxxxxxxxxx>, alsa-devel@xxxxxxxxxxxxxxxx, iommu@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, Leo Yan <leo.yan@xxxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, Andy Gross <andy.gross@xxxxxxxxxx>
In-reply-to: <20230627-topic-more_bindings-v1-9-6b4b6cd081e5@linaro.org>
References: <20230627-topic-more_bindings-v1-0-6b4b6cd081e5@linaro.org> <20230627-topic-more_bindings-v1-9-6b4b6cd081e5@linaro.org>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0

On 27/06/2023 18:24, Konrad Dybcio wrote:
> The description of reg[1] says that register is optional. Adjust
> minItems to make it truly optional.
> 
> Fixes: 12f40018b6a9 ("dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---

This patch does not make sense. It wasn't also tested. The code
(minItems) is already there.

Best regards,
Krzysztof

Follow-Ups:
- Re: [PATCH 09/11] dt-bindings: arm: msm: kpss-acc: Make the optional reg truly optional
  - From: Krzysztof Kozlowski

References:
- [PATCH 00/11] Even more msm bindings fixes
  - From: Konrad Dybcio
- [PATCH 09/11] dt-bindings: arm: msm: kpss-acc: Make the optional reg truly optional
  - From: Konrad Dybcio

Prev by Date: Re: [PATCH v2 00/11] Fix support for System Suspend for CS35L41 HDA
Next by Date: Re: [PATCH] ASoC: SOF: ipc4-topology: fix application of sizeof to pointer
Previous by thread: Re: [PATCH 09/11] dt-bindings: arm: msm: kpss-acc: Make the optional reg truly optional
Next by thread: Re: [PATCH 09/11] dt-bindings: arm: msm: kpss-acc: Make the optional reg truly optional
Index(es):
- Date
- Thread

[Index of Archives] [ALSA User] [Linux Audio Users] [Pulse Audio] [Kernel Archive] [Asterisk PBX] [Photo Sharing] [Linux Sound] [Video 4 Linux] [Gimp] [Yosemite News]