Hi, On Thu, 20 Jul 2023, Brent Lu wrote: > We add a helper funcion to detect amplifier number according to device instance > in ACPI table so the SOF_MAX98390_TWEETER_SPEAKER_PRESENT flag and a dmi quirk > for 4-amplifier configuration could be safely removed. > > Also refactory the max_98390_hw_params() function to use an array to handle the > TDM parameter. > > Amplifier number detection and TDM parameter are tested on two Chromebooks. One > with 2 MAX98390 and one with 4 MAX98390 amplifier. > > > *** BLURB HERE *** this looks like a nice cleanup, thanks Brent. For the series: Acked-by: Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx> Minor nit: some spelling erros in cover letter (funcion->function, refactory->refactor, BLURB HERE left), but I think the intent comes across. Br, Kai
