Hi, Krzysztof,
Thank you very much for your advice,
but I have a few questions I'd like to discuss with you
On 18/07/2023 16:41, krzysztof.kozlowski@xxxxxxxxxx wrote:
> On 17/07/2023 13:58, wangweidong.a@xxxxxxxxxx wrote:
>> From: Weidong Wang <wangweidong.a@xxxxxxxxxx>
>>
>> The AW88261 is an I2S/TDM input, high efficiency
>> digital Smart K audio amplifier with an integrated 10.25V
>> smart boost convert
> So all your commits are doing the same?
I will modify the commit information and differentiate the commit
information for each file
>>
>> Signed-off-by: Weidong Wang <wangweidong.a@xxxxxxxxxx>
>> ---
>> sound/soc/codecs/aw88261/aw88261_lib.c | 997 +++++++++++++++++++++++++
>> sound/soc/codecs/aw88261/aw88261_lib.h | 91 +++
>> 2 files changed, 1088 insertions(+)
>> create mode 100644 sound/soc/codecs/aw88261/aw88261_lib.c
>> create mode 100644 sound/soc/codecs/aw88261/aw88261_lib.h
>>
>> diff --git a/sound/soc/codecs/aw88261/aw88261_lib.c b/sound/soc/codecs/aw88261/aw88261_lib.c
>> new file mode 100644
>> index 000000000000..b8f00708dacf
>> --- /dev/null
>> +++ b/sound/soc/codecs/aw88261/aw88261_lib.c
>> @@ -0,0 +1,997 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +//
>> +// aw88261_lib.c -- ACF bin parsing and check library file for aw88261
>> +//
>> +// Copyright (c) 2023 awinic Technology CO., LTD
>> +//
>> +// Author: Jimmy Zhang <zhangjianming@xxxxxxxxxx>
>> +// Author: Weidong Wang <wangweidong.a@xxxxxxxxxx>
>> +//
>> +
>> +#include <linux/crc8.h>
>> +#include <linux/i2c.h>
>> +#include "aw88261_lib.h"
>> +#include "aw88261_device.h"
>> +
>> +#define AW88261_CRC8_POLYNOMIAL 0x8C
>> +DECLARE_CRC8_TABLE(aw_crc8_table);
>> +
>> +static char *profile_name[AW88261_PROFILE_MAX] = {
> Cannot be const char *?
I will modify it according to your suggestion
...
>> +EXPORT_SYMBOL_GPL(aw88261_dev_load_acf_check);
> Why?
This function is also called in the aw88261.c file
Best regards,
Weidong Wang
