At Wed, 6 Aug 2008 14:35:48 +0100,
Mark Brown wrote:
>
> On Wed, Aug 06, 2008 at 03:21:37PM +0200, Takashi Iwai wrote:
> > Mark Brown wrote:
>
> > > + switch (reg) {
> > > + default:
> > > + return wm8580_read_reg_cache(codec, reg);
> > > + }
>
> > Any addition in future? Otherwise let's remove unneeded switch.
>
> There are some non-cachable status registers for functions not yet
> supported in the driver.
>
> > > +#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
>
> > Could you rewrite the code to follow the recent i2c framework?
> > Then you can reduce lots of codes.
>
> This and every other I2C driver in ASoC :/ .
cs4270.c was already converted by Timur :)
> Since the system I'm using
> to develop this driver doesn't have a current enough I2C subsystem
> available at the moment to use the new framework it's not an ideal
> candidate for first conversion.
>
> Doing this conversion is on my todo list but getting at least enough of
> v2 merged to allow dynamic codec driver registration should probably be
> done first.
OK, then I'll apply your patch as is.
Let's see whether we do convert them soon later or wait for ASoC v2.
thanks,
Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
