On Tue, Jul 11, 2023 at 09:00:18AM +0900, Kuninori Morimoto wrote:
>
> Hi Rob
>
> Thank you for reviewing
>
>
> > > diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> > > index 8a821dec9526..d9808b130e8d 100644
> > > --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> > > +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> > > @@ -9,6 +9,20 @@ title: Renesas R-Car Sound Driver
> > > maintainers:
> > > - Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
> > >
> > > +definitions:
> >
> > $defs
>
> Hmm... many drivers are using "definitions" ?
Patches welcome to change them. I don't think it's many (not counting
types.yaml). Use of "definitions" or "$defs" is an exception.
> This kind of indication is very confusable...
"definitions" was common convention in early json-schema. "$defs" was
added to the specification to standardize it.
> > > port:
> > > - $ref: audio-graph-port.yaml#/definitions/port-base
> > > - unevaluatedProperties: false
> > > - patternProperties:
> > > - "^endpoint(@[0-9a-f]+)?":
> > > - $ref: audio-graph-port.yaml#/definitions/endpoint-base
> > > - properties:
> > > - playback:
> > > - $ref: /schemas/types.yaml#/definitions/phandle-array
> > > - capture:
> > > - $ref: /schemas/types.yaml#/definitions/phandle-array
> > > - unevaluatedProperties: false
> > > + $ref: "#/definitions/port-def"
> >
> > It would be better if users just always used "ports { port {}; };" even
> > in the single port case.
>
> "ports" support is added, we can't modify past.
I don't understand. The graph APIs all work the same with or without
'ports'. Changing the DT shouldn't affect the ABI.
Rob
