At Wed, 06 Aug 2008 08:56:40 +0200, Rene Herman wrote: > > On 06-08-08 08:42, Rene Herman wrote: > > > This reworks snd_ad1848_probe(), making for IMO significantly more > > straightforward reading. > > > > The original had a somewhat odd try-loop where it not only waited for > > the codec to come out of init but also retried a failed basic detect > > which seems to not make sense. Except for that, the detection logic > > should be unchanged. > > > > I am by the way rather unsure what it is that the spin_lock is trying to > > protect us from here. What's the error scenario if we just not take it? > > We aren't live yet... > > > > Next step is folding this into snd_wss_probe() directly. > > Oh, but now that I decided to do so not immediately, this first one > should remeber to switch back to MODE 1, if only for cleanliness. > > New version. Never mind the somewhat ugly goto. Disappears when folded > again. Thanks, a nice clean up. Applied now. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
