Re: [PATCH] ASoC: simple-card: add trigger-stop entry parser

[Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>]

Hi Maxim

Thank you for your patch

> It may be useful to specify trigger-stop for some DMA-based simple
> audio card. So add this "trigger-stop" device tree entry parser.
> 
> Signed-off-by: Maxim Kochetkov <fido_max@xxxxxxxx>
> ---
(snip)
> +	const char *str;
> +	struct {
> +		char *name;
> +		unsigned int val;
> +	} of_trigger_table[] = {
> +		{ "default",	SND_SOC_TRIGGER_ORDER_DEFAULT },
> +		{ "ldc",	SND_SOC_TRIGGER_ORDER_LDC },
> +	};
(snip)
> +		ret = of_property_read_string(np, "trigger-stop", &str);

The name of "LDC" is from initials of "Link -> DAI -> Component".
Thus, people want to know what does it mean.
You need to update DT doc/yaml too :)

Or maybe like this ?

	// 0 : Link
	// 1 : DAI
	// 2 : Component
	trigger-stop = <0, 1, 2>; // default
	trigger-stop = <0, 2, 1>; // LDC

And please add paired "trigger-start" or add comment like
/* ADD .trigger-start here */ or something.
Unbalanced implementation is very confusable.


Thank you for your help !!

Best regards
---
Kuninori Morimoto