On 7/13/23 10:03, Takashi Iwai wrote:
On Wed, 12 Jul 2023 21:13:25 +0200,
Ivan Orlov wrote:
Extend 'pcmtest' virtual driver with 'open' callback error injection
functionality, as it already can inject errors into other PCM callbacks.
Fix the driver to use already defined variables where it is possible.
Additionally, decrease the buffer filling overhead with conditional
reminder calculation in the 'inc_buf_pos' inline function.
Signed-off-by: Ivan Orlov <ivan.orlov0322@xxxxxxxxx>
Please avoid mixing different changes in a single patch.
This patch does three completely different things, and they should be
split.
- New inject_open_err parameter
- Optimization of inc_buf_pos()
- Optimization of check_buf_block_ni() and fill_block_pattern_n()
The latter two could be put in a single patch as minor optimizations,
but the introduction of a new option doesn't fit with the rest.
thanks,
Takashi
Hi Takashi,
Thank you for the review. I'll split the patch and send the changes again.
Kind regards,
Ivan Orlov
