> On 31-07-08 21:03, Krzysztof Helt wrote: > > Takashi, you already applied these but is it possible to still get my > Acked-by (or Reviewed-by, whatever you want) on them? When a problem is > bisected to one of these, people tend to put the people in the patch > tags in CC and I looked at them and would like to be informed of any > trouble. I tested most users by now, and we'll get the azt2320 fixed > before this hits the streets but I still like to be in the loop on any > traffic concerning them. > > Acked-by: Rene Herman <rene.herman@xxxxxxxxx> > > (or Reviewed-by, Tested-by, ...) > > Below comments not important: > > > @@ -679,23 +679,25 @@ static int __devinit snd_opl3sa2_probe(s > > [ ... ] > > > - chip->cs4231 = cs4231; > > - if ((err = snd_cs4231_pcm(cs4231, 0, NULL)) < 0) > > + chip->wss = wss; > > + err = snd_wss_pcm(wss, 0, NULL); > > + if (err < 0) > > return err; > > - if ((err = snd_cs4231_mixer(cs4231)) < 0) > > + err = snd_wss_mixer(wss); > > + if (err < 0) > > return err; > > if ((err = snd_opl3sa2_mixer(chip)) < 0) > > return err; > > <mumble> > I think about doing some code improvements in the opl3sa2 e.g. use WSS tlv macros instead of the tlv macros defined localy. Regards, Krzysztof ---------------------------------------------------------------------- Tani Telefon! Sprawdz >>> http://link.interia.pl/f1ec0 _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
