Re: [PATCH 2/2] ALSA: emu10k1: track loss of external clock on E-MU cards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 11, 2023 at 07:28:22AM +0200, Takashi Iwai wrote:
Again, snd_ctl_notify() itself doesn't need the rwsem lock at all.

ah, you mean i could fully release it before the notification.

It's snd_ctl_notify_one() that needs a more careful call pattern.

i suppose that's because the snd_ctl_layer callbacks might require it.
i would recommend actually documenting that.

And, that ugly implementation is a thing to be improved in future in
ALSA core side.

it is? like, really? or is it just a far-off idea with no concrete plan whatsoever? is there an actual problem to solve, or is it just a sense of "yeah, this could be nicer ... somehow"? i mean, this is the mixer - one would be hard-pressed to find an actual bottleneck in there.

regards



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux