On Mon, Jul 10, 2023 at 12:10:03PM +0100, Mark Brown wrote: > On Mon, Jul 10, 2023 at 02:08:00PM +0300, Andy Shevchenko wrote: > > On Mon, Jul 10, 2023 at 12:04:35PM +0100, Mark Brown wrote: > > > On Mon, Jul 10, 2023 at 01:27:47PM +0300, Andy Shevchenko wrote: > > > > > > > Convert the users to SPI_CONTROLLER_NO_?X and SPI_CONTROLLER_MUST_.X > > > > and kill the not used anymore definitions. > > > > The above is not what this change does: > > > How to improve it? I was sure that the form of "converting to something and > > something" is clear... > > > > > - controller->flags = SPI_MASTER_MUST_RX | SPI_MASTER_MUST_TX; > > > > + controller->flags = SPI_CONTROLLER_MUST_RX | SPI_CONTROLLER_MUST_TX; > > The change here is not the change that is described above. Okay, than you for elaboration and review. With the assumed split it should be addressed. Besides that, should I resend the entire series or only this one? -- With Best Regards, Andy Shevchenko
