On Fri, Jul 07, 2023 at 09:35:44AM +0200, Johan Hovold wrote: > On Wed, Jul 05, 2023 at 01:57:23PM +0100, Srinivas Kandagatla wrote: > > +static const DECLARE_TLV_DB_SCALE(line_gain, -3000, 150, -3000); > This looks wrong, and indeed that forth argument appears to be a mute > flag. I guess that one should have been 0 (false) here? Yes, it is - it's for flagging if the lowest value is mute (many devices integrate mute into a volume control). > Headphone output also appears to be way too loud by default with this > patch (alone) applied. Perhaps it's just the default mixer settings need > to be updated to match? Some of the discussion on IRC suggested that this might be the case.
Attachment:
signature.asc
Description: PGP signature
