On 7/5/23 19:16, Mark Brown wrote: > On Wed, Jul 05, 2023 at 04:43:41PM +0300, Cristian Ciocaltea wrote: > >> +static int acp5x_max98388_hw_params(struct snd_pcm_substream *substream, >> + struct snd_pcm_hw_params *params) >> +{ >> + struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream); >> + struct snd_soc_dai *dai = snd_soc_card_get_codec_dai(rtd->card, >> + ACP5X_MAX98388_DAI_NAME); >> + int ret; >> + >> + ret = snd_soc_dai_set_fmt(dai, >> + SND_SOC_DAIFMT_CBS_CFS | SND_SOC_DAIFMT_I2S | >> + SND_SOC_DAIFMT_NB_NF); >> + if (ret < 0) >> + dev_err(dai->dev, "Failed to set format: %d\n", ret); >> + >> + return ret; >> +} > > This never varies, why not just set it up statically in the dai_link? Right, will handle this in v3. Thanks, Cristian