make data->system.parm1 avoid double assignment. but note writes "RT message with two parameters to UMP" is one of assignment is for system.parm2? I'm not sure, Could you help check it out? Thank you! Signed-off-by: Minjie Du <duminjie@xxxxxxxx> --- sound/core/seq/seq_ump_convert.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/core/seq/seq_ump_convert.c b/sound/core/seq/seq_ump_convert.c index eb1d86ff6..60e637149 100644 --- a/sound/core/seq/seq_ump_convert.c +++ b/sound/core/seq/seq_ump_convert.c @@ -713,7 +713,6 @@ static int system_2p_ev_to_ump_midi1(const struct snd_seq_event *event, unsigned char status) { data->system.status = status; - data->system.parm1 = (event->data.control.value >> 7) & 0x7f; data->system.parm1 = event->data.control.value & 0x7f; return 1; } -- 2.39.0