Re: [PATCH] ASoC: codecs: wcd938x: fix missing mbhc init error handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> MBHC initialisation can fail so add the missing error handling to avoid
> dereferencing an error pointer when later configuring the jack:

I would prefer a different wording approach for a desirable change here.
How do you think about a variant like the following?


MBHC initialisation can fail.
Such a data processing situation can be indicated by background information
as follows.

    Unable to handle kernel paging request at virtual address fffffffffffffff8

    pc : wcd_mbhc_start+0x28/0x380 [snd_soc_wcd_mbhc]
…
    Call trace:
…

Thus add the missing error handling to avoid dereferencing an error pointer
when configuring the jack later.
…


Regards,
Markus




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux