On Mon, 26 Jun 2023 17:36:20 +0200, Krzysztof Kozlowski wrote: > On 26/06/2023 13:09, Hal Feng wrote: >> Add bindings for the PWM-DAC controller on the JH7110 >> RISC-V SoC by StarFive Ltd. >> >> Signed-off-by: Hal Feng <hal.feng@xxxxxxxxxxxxxxxx> >> --- >> .../sound/starfive,jh7110-pwmdac.yaml | 76 +++++++++++++++++++ >> 1 file changed, 76 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/starfive,jh7110-pwmdac.yaml >> >> diff --git a/Documentation/devicetree/bindings/sound/starfive,jh7110-pwmdac.yaml b/Documentation/devicetree/bindings/sound/starfive,jh7110-pwmdac.yaml >> new file mode 100644 >> index 000000000000..91a4213f2bd8 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/starfive,jh7110-pwmdac.yaml >> @@ -0,0 +1,76 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/sound/starfive,jh7110-pwmdac.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: StarFive JH7110 PWM-DAC Controller >> + >> +description: | > > Do not need '|' unless you need to preserve formatting. Got it. Will drop it later. > >> + The PWM-DAC Controller uses PWM square wave generators plus RC filters to >> + form a DAC for audio play in StarFive JH7110 SoC. This audio play controller >> + supports 16 bit audio format, up to 48K sampling frequency , up to left > > No space before , Will fix. > >> + and right dual channels. >> + >> +maintainers: >> + - Hal Feng <hal.feng@starfivetec > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Thanks for your review. Best regards, Hal
