On 6/28/23 16:49, Andy Shevchenko wrote: > On Wed, Jun 28, 2023 at 10:51:27PM +0200, Amadeusz Sławiński wrote: >> PCI IDs for Intel HDA are duplicated across quite a few drivers, due to >> various configurations and historical reasons. Currently almost all uses >> of HDA PCI IDs have corresponding comment telling which platform it is. >> Additionally there are some inconsistencies between drivers about which >> ID corresponds to which device. >> >> Simplify things, by adding PCI IDs to global header and make use of them >> in drivers. This allows for removal of comments by having IDs themselves >> being self explanatory. Additionally it allows for removal of existing >> inconsistencies by having one source of truth. > > I'm in favour of this series. It allows to use PCI_DEVICE_DATA() in many places. > With that said, I think you can also add some more definitions to PCI IDs header > for the sake of being able to use that macro. I don't have any objections on the change. The big open is how we add new definitions without a 3-way deadlock between PCI, sound and ASoC trees, and how those definitions can be added to the -stable trees. This isn't an hypothetical case, we have 2 pending submissions for LunarLake [1] and ArrowLake [2] which will be provided as soon as the merge window closes. It's not clear to me if Bjorn is ok to let those audio-specific PCI IDs go the audio trees, and how things would work between Mark and Takashi. [1] https://github.com/thesofproject/linux/pull/4425 [2] https://github.com/thesofproject/linux/pull/4437
