On 21. 06. 23 15:08, Mark Brown wrote:
On Tue, Jun 20, 2023 at 06:08:26PM -0400, Nícolas F. R. A. Prado wrote:
- const int duration_s = 4, margin_ms = 100;
+ const int duration_s = 2, margin_ms = 100;
This doesn't scale the margin with the duration which will affect the
sensitivity of the test to misclocking. It should make it less
sensitive which is *probably* safer but at least worth noting.
We might also have issues with some of the lower sample rates, IIRC some
devices are constrained in ways that mean they want a minimum buffer
size which is harder to satisfy with very short playbacks and low sample
rates.
I don't know why Jaroslav picked the 4s number here.
You basically replied yourself. The values (time + margin) were picked to do
the DMA test for a reasonable time - based on my experience.
I think that the problem is somewhere else here. The overall test timeout
should be calculated dynamically. All tests may be queried for the maximal
expected interval based on the hardware/software capabilities. It's a bit
pitfall to have a fixed time limit where the realtime tests depend on the
number of devices.
Jaroslav
--
Jaroslav Kysela <perex@xxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
