On 19/06/23 11:02, Mukunda,Vijendar wrote: > On 12/06/23 15:28, Vijendar Mukunda wrote: >> This patch series add support for >> - Platform device creation for SoundWire Manager instances and >> PDM controller. >> - SoundWire DMA driver. >> - Interrupt handling for SoundWire manager related interrupts, >> SoundWire DMA interrupts and ACP error interrupts. >> - ACP PCI driver PM ops modification with respect to SoundWire >> Power modes. >> >> Changes since v3: >> - use pdev_config instead of pdev_mask in the code. >> - define platform device configuration macros rather than enums >> - add comments for MIPI DisCo version >> - refactor SoundWire DMA start/stop sequence using single >> function >> - refactor "acp_reset" flag related functionality. >> >> Changes since v2: >> - add comments in irq handler. >> - remove workqueue for SoundWire DMA interrupts and use thread >> implementation for DMA interrupt handling. >> - add error checks in sdw_amd_scan_controller() >> - remove passing "acp_lock" as platform resource for SoundWire DMA driver >> and PDM driver. >> - retrieve "acp_lock" reference from parent driver directly and >> use the reference in SoundWire DMA driver. >> - add handling for acp pci driver probe even when no ACP PDM or >> SoundWire manager platform devices created. >> - Fix indentation for acp_sdw_dma_count structure variables. >> - Use macro instead of hard coded values for FIFO offset and PTE offset. >> - Change pm_runtime enable sequence in SoundWire DMA driver >> probe function. >> - Refactor system level resume callback in SoundWire DMA >> >> Changes since v1: >> - update "soundwire" as "SoundWire" in code. >> - add comments for platform device mask and platform device >> count >> - remove unused variables in acp pci driver private data >> structure >> - refactor dma enable register structures in SoundWire DMA driver >> - add TODO comments in IRQ handler >> - update IRQ mask values using bit macros >> - Fix build error reported in Makefile >> - rename "sdw_dma_stream_instance" structure name as "acp_sdw_dma_stream" > @Mark: We have provided replies for upstream review comments for V4 patch set. > We are going to push as supplement patches for minor fixes. > Should I resend the patch series? @Bossart: If you don't have further comments, could you please provide reviewed-by tag for this patch series? >> >> Vijendar Mukunda (9): >> ASoC: amd: ps: create platform devices based on acp config >> ASoC: amd: ps: handle SoundWire interrupts in acp pci driver >> ASoC: amd: ps: add SoundWire dma driver >> ASoC: amd: ps: add SoundWire dma driver dma ops >> ASoC: amd: ps: add support for SoundWire DMA interrupts >> ASoC: amd: ps: add pm ops support for SoundWire dma driver >> ASoC: amd: ps: enable SoundWire dma driver build >> ASoC: amd: update comments in Kconfig file >> ASoC: amd: ps: add acp_reset flag check in acp pci driver pm ops. >> >> sound/soc/amd/Kconfig | 3 +- >> sound/soc/amd/ps/Makefile | 2 + >> sound/soc/amd/ps/acp63.h | 172 ++++++++++- >> sound/soc/amd/ps/pci-ps.c | 419 +++++++++++++++++++++++-- >> sound/soc/amd/ps/ps-sdw-dma.c | 555 ++++++++++++++++++++++++++++++++++ >> 5 files changed, 1115 insertions(+), 36 deletions(-) >> create mode 100644 sound/soc/amd/ps/ps-sdw-dma.c >>
