On 2023/6/13 03:06, Mark Brown wrote:
On Mon, Jun 12, 2023 at 05:00:46PM +0800, YingKun Meng wrote:+ if (ls_card->mclk_fs) { + mclk = ls_card->mclk_fs * params_rate(params); + ret = snd_soc_dai_set_sysclk(cpu_dai, 0, mclk, + SND_SOC_CLOCK_OUT); + if (ret < 0) { + dev_err(codec_dai->dev, "cpu_dai clock not set\n"); + return ret; + }Does this need to be in the machine driver - this isn't configuring an external clock, it's just within the SoC, so presumably the driver for the SoC DAI can just set itself up.
I think so. The driver for the SoC DAI cannot obtain the MCLK frequency of I2S bus from the clock subsystem.
