Re: [PATCH 10/10] wss_lib: use wss detection code instead of ad1848 one

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 29-07-08 16:31, Takashi Iwai wrote:

>> 2) debug printks
>>
>> For one example here, see:
>>
>> http://mailman.alsa-project.org/pipermail/alsa-devel/2008-July/008978.html
>>
>> /snd_wss_debug
>>
>> Bad, bad, triply bad.
> 
> This change is actually buggy.  Each second printk should have no
> KERN_* prefix.  KERN_* prefix is only for the beginning of the line.

See how these formatting "fixes" made me miss that? ;-)

> A more better fix would be to rewrite this to use a loop, BTW.

Rene.

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux