On Tue, Jun 13, 2023 at 04:24:28PM +0200, Takashi Iwai wrote: > Mark Brown wrote: > > BTW I was just looking at reg_raw_update_once() and I can't figure out > > why it's trying to do what it's doing - it does a read to check if it's > > seen the register before and then does an _update_bits() if the register > > hasn't been cached yet, apparently trying suppress duplicate writes but > > possibly deliberately discarding changes to multiple bitfields in the > > same register. That's not what the non-regmap path does, it'll only > > discard noop changes to the same bitfield. > Yes, it's a quite hackish way of optimization of the initialization. > Since HD-audio codec has no known default values unlike normal codecs, > it needs to initialize itself only at the first access, and this > helper does it. Ah, if it's just suppressing the write the code should just be removed. regmap_update_bits() already suppresses noop writes so unless we might write a different value to the register later the effect will be the same. I can send a patch.
Attachment:
signature.asc
Description: PGP signature
