Hey! On Mon, Jun 12, 2023 at 04:56:14PM +0800, YingKun Meng wrote: > From: Yingkun Meng <mengyingkun@xxxxxxxxxxx> > > The audio card uses loongson I2S controller present in > 7axxx/2kxxx chips to transfer audio data. > > On loongson platform, the chip has only one I2S controller. > > Signed-off-by: Yingkun Meng <mengyingkun@xxxxxxxxxxx> I got 2 copies of this patch, but none of the rest of the series appears to be threaded with it. > .../sound/loongson,ls-audio-card.yaml | 70 +++++++++++++++++++ > 1 file changed, 70 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml > > diff --git a/Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml b/Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml > new file mode 100644 > index 000000000000..61e8babed402 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/loongson,ls-audio-card.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/loongson,ls-audio-card.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Loongson 7axxx/2kxxx ASoC audio sound card driver > + > +maintainers: > + - Yingkun Meng <mengyingkun@xxxxxxxxxxx> > + > +description: > + The binding describes the sound card present in loongson > + 7axxx/2kxxx platform. The sound card is an ASoC component > + which uses Loongson I2S controller to transfer the audio data. > + > +properties: > + compatible: > + const: loongson,ls-audio-card Reviewing sound stuff is beyond my pay grade, so forgive me if I am off the rails here, but this (and the "x"s in the description) look a bit odd. Recently, we've noticed quite a few loongson dt-bindings attempting to use a single compatible for many different chips. Usually you have individual compatibles for the various SoCs with this core, which can fall back to a generic one, rather than just adding a generic compatible for all devices. As far as I know, there's several SoCs fitting 2kxxx, and the format being used elsewhere is "loongson,ls2k1000" etc. Cheers, Conor.
Attachment:
signature.asc
Description: PGP signature
