On 10/06/2023 16:18, Shenghao Ding wrote: > Create tas2781.yaml for tas2781 driver. > > Signed-off-by: Shenghao Ding <13916275206@xxxxxxx> We keep telling you that your email threading is broken. It still is makes reviewers life more difficult. Maintainer as well as applying is not straightforward. Why this is not improved? > > --- > Changes in v5: > - remove ti,broadcast-addr > - remove address-cells > - remove size-cells > - put compatible item first in properties > - change the maxItems of reg from 4 to 8 > - remove white space around <> > - correct the reg format to <0x38>, <0x3a> etc > - remove '\t' in the file > - correct a comment in the example > --- > .../devicetree/bindings/sound/ti,tas2781.yaml | 73 +++++++++++++++++++ > 1 file changed, 73 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/ti,tas2781.yaml > > diff --git a/Documentation/devicetree/bindings/sound/ti,tas2781.yaml b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml > new file mode 100644 > index 000000000000..61db14a39630 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/ti,tas2781.yaml > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright (C) 2022 - 2023 Texas Instruments Incorporated > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/ti,tas2781.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments TAS2781 SmartAMP > + > +maintainers: > + - Shenghao Ding <shenghao-ding@xxxxxx> > + > +description: > + The TAS2781 is a mono, digital input Class-D audio amplifier > + optimized for efficiently driving high peak power into small > + loudspeakers. Integrated an on-chip DSP supports Texas Instruments > + Smart Amp speaker protection algorithm. The integrated speaker > + voltage and current sense provides for real time > + monitoring of loudspeaker behavior. > + > +allOf: > + - $ref: dai-common.yaml# > + > +properties: > + compatible: > + enum: > + - ti,tas2781 > + > + reg: > + description: > + I2C address, in multiple tas2781s case, all the i2c address > + aggreate as one Audio Device to support multiple audio slots. > + maxItems: 8 > + items: > + minimum: 0x38 > + maximum: 0x3f It does not look like you tested the bindings, at least after quick look. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). You miss here minItems. Best regards, Krzysztof
