On Thu, Jun 08, 2023 at 06:43:09PM +0800, Walker Chen wrote: > On 2023/6/8 18:15, Mark Brown wrote: > > I can't find the comments you're referring to in there. > You should see the following comments in the link above: > > + #define CLKPOL_BIT 5 > > + #define TRITXEN_BIT 4 > > + #define ELM_BIT 3 > > + #define SYNCM_BIT 2 > > + #define MS_BIT 1 > Instead of these *_BIT defines as plain numbers you can defined them using > BIT() macro and use macros in place instead of The usual pattern is to have defines for both the shift and the mask, not just one.
Attachment:
signature.asc
Description: PGP signature
