Re: [PATCH v4 5/6] ALSA: hda/tas2781: Add tas2781 HDA driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 06, 2023 at 06:08:51PM +0200, Takashi Iwai wrote:
> Shenghao Ding wrote:

> > +	//Lenovo devices
> > +	if ((subid == 0x387d) || (subid == 0x387e) || (subid == 0x3881)
> > +		|| (subid == 0x3884) || (subid == 0x3886) || (subid == 0x38a7)
> > +		|| (subid == 0x38a8) || (subid == 0x38ba) || (subid == 0x38bb)
> > +		|| (subid == 0x38be) || (subid == 0x38bf) || (subid == 0x38c3)
> > +		|| (subid == 0x38cb) || (subid == 0x38cd))
> > +		tas_priv->catlog_id = LENOVO;
> > +	else
> > +		tas_priv->catlog_id = OTHERS;

> Hmm, I don't like checking subid here, but we can live with it for
> now...

Might be more idiomatically/neatly written as a switch statement though.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux