On Tue, 06 Jun 2023 13:15:20 +0200, Jaroslav Kysela wrote: > > On 06. 06. 23 11:40, Takashi Iwai wrote: > > We don't need to change the numid at each time snd_ctl_rename_id() is > > called, as the control element size itself doesn't change. Let's keep > > the previous numid value. > > I would also highlight in the comment that snd_ctl_rename_id() should > be used only in the card initialization phase. It may cause issues > with the user space (persistent numid) for the dynamic controls. Sounds good. I'll add the note in the commit. > Reviewed-by: Jaroslav Kysela <perex@xxxxxxxx> Thanks! Takashi