Hi Jonathan, Andy, On Mon, 5 Jun 2023 18:05:47 +0100 Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> wrote: > On Mon, 5 Jun 2023 12:45:24 +0300 > Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > ... > > > > > + default: > > > > > + /* FIXME: learn about min for other iio values */ > > > > > > > > I believe in a final version this comment won't be here. > > > > > > We have the same FIXME comment in the iio_channel_read_max() function I > > > copied to create this iio_channel_read_min() and, to be honest, I > > > don't really know how to handle these other cases. > > > > > > In this series, I would prefer to keep this FIXME. > > > > I see, Jonathan needs to be involved here then. > > It's really more of a TODO when someone needs it than a FIXME. > I'm not particularly keen to see a bunch of code supporting cases > that no one uses, but it's useful to call out where the code would > go if other cases were to be supported. > > Perhaps soften it to a note that doesn't have the work FIXME in it. > > Jonathan > Right, I will change to /* TODO: learn about max for other iio values */ in the next iteration (both iio_channel_read_max() and iio_channel_read_min()) Regards, Hervé > > > > > > > > + return -EINVAL; > > >
