Hi Kuninori,
On Mon, Jun 05, 2023 at 12:28:14AM +0000, Kuninori Morimoto wrote:
>
> Hi Alvin
>
> Thank you for the patch
>
> > --- a/sound/soc/generic/simple-card.c
> > +++ b/sound/soc/generic/simple-card.c
> > @@ -181,6 +181,7 @@ static int simple_link_init(struct asoc_simple_priv *priv,
> > {
> > struct device *dev = simple_priv_to_dev(priv);
> > struct snd_soc_dai_link *dai_link = simple_priv_to_link(priv, li->link);
> > + char prop[128];
> > int ret;
> >
> > ret = asoc_simple_parse_daifmt(dev, node, codec,
> > @@ -188,6 +189,9 @@ static int simple_link_init(struct asoc_simple_priv *priv,
> > if (ret < 0)
> > return 0;
> >
> > + snprintf(prop, sizeof(prop), "%ssymmetric-clock-roles", prefix);
> > + dai_link->symmetric_clock_roles = of_property_read_bool(node, prop);
> > +
> > dai_link->init = asoc_simple_dai_init;
> > dai_link->ops = &simple_ops;
>
> looks good to me.
>
> simple-card / audio-graph-card / audio-graph-card2 want to support same settings
> (But unfortunately it is not completely synchronized...).
>
> Could you please add same settings or indicate it on the comment
> (like /* FIXME support symmetric-clock-roles here */, etc)
> on audio-graph-card, if you create v2 patch ?
>
> Thank you for your help !!
Sure. If I send a v2, I will add a patch for audio-graph-card as well. :)
Kind regards,
Alvin
