On Thu, May 25, 2023 at 02:38:08PM +0100, Srinivas Kandagatla wrote: > During x13s audio testing we hit few corner cases due to issues > in codec drivers and some obvious code bugs. > > Here are the fixes for those issues, mostly the issues are around > devices loosing the sync in between runtime pm suspend resume path. > > With codec fixes along with these fixes, audio on x13s is pretty stable. > > Thanks, > Srini > > Changes since v1: > - dropped runtime pm changes patch as unable to reproduced it anymore > - fixed clk stop flag as suggested by Pierre > - rebased on top of linux-next I tried to update to this series on my 6.4-rc5 branch for the X13s and the above changes appear to lead to breakages again. Specifically, with the updated clk stop flag (simple_clk_stop_capable) I see: [ 14.789533] wcd9380-codec sdw:0:0217:010d:00:3: Slave 1 state check1: UNATTACHED, status was 1 [ 14.789717] qcom-soundwire 3330000.soundwire-controller: qcom_swrm_irq_handler: SWR bus clsh detected [ 14.796164] wcd9380-codec sdw:0:0217:010d:00:3: Slave 1 state check1: UNATTACHED, status was 1 and without the runtime pm patch that you dropped in v2 I get intermittent (e.g. twice in five boots): [ 11.527301] snd-sc8280xp sound: ASoC: adding FE link failed [ 11.527409] snd-sc8280xp sound: ASoC: topology: could not load header: -517 [ 11.527557] qcom-apm gprsvc:service:2:1: tplg component load failed-517 [ 11.527640] qcom-apm gprsvc:service:2:1: ASoC: error at snd_soc_component_probe on gprsvc:service:2:1: -22 [ 11.528079] snd-sc8280xp sound: ASoC: failed to instantiate card -22 [ 11.533388] snd-sc8280xp: probe of sound failed with error -22 Again, this was with 6.4-rc5, but these problems are likely still there also with linux-next. Johan
