Re: [PATCH v2 00/21] ASoC: replace dpcm_playback/capture to playback/capture_only

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pierre-Louis
Cc Amadeusz

Thank you for your feedback

> > In case of CPU:Codec = 1:N, and if its validation were
> > 
> > 	CPU   : OK
> > 
> > 	Codec : OK
> > 	Codec : NG
> > 	...
> > 
> > Current soc_get_playback_capture() will have has_playback/capture = 1
> > evan though one of Codec was NG.
> > I think it should be error, but am I right ?
> 
> Indeed, we should only enable playback (resp. capture) when all codec
> dais have the same settings. We should revert the logic here IMHO to go
> from 'at least one' to 'all'.

Thank you !
The code can be more cleanup if my understanding was correct.

As my v1 patch-set and Amadeusz revealed, DPCM BE Codec has been not checked,
and Intel drivers rely on it [1].
But it seems it is using complex driver style, and also I can't test
it, because I can't access to it.

[1] https://lore.kernel.org/r/ab3f0c0a-62fd-a468-b3cf-0e4b59bac6ae@xxxxxxxxxxxxxxx

I'm happy if Intel drivers are updated around it.
(Add missing .channels_min or update snd_soc_dai_stream_valid() (?))

I will post remaining patch-set first, thus it is not rush,
and of course not mandatory though


Thank you for your help !!

Best regards
---
Kuninori Morimoto



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux