Hi Amadeusz Thank you for your review and feedback > patches look ok - I haven't run tests yet on v3, will try to get results > tomorrow. However looking at those assignments again, I wonder if we > really need them to be "negative" ones? Can't we just have some simple > fields like playback and capture (similar to dpcm_playback & > dpcm_capture from before). My concern is that having fields with "_only" > in name requires them to be handled properly - like in above code, while > having just "playback" and "capture" would be just simple assignment and > in the end a lot easier to understand. Is there any reason you chose to > use the *_only fields? Not a super big reason, but want to keep compatibility as much as possible. The driver which get effect from this patch is only DPCM user if it uses playback/capture_only. I think DPCM user < normal user. If we want to switch to use playback/capture flag from _only flag, we want have such additional patch-set instead of "change everything" patch-set ? And my understand is "playback/capture_only" are "option" flag, "playback/capture" are "necessary" flag. I like less "necessary settings" driver :) Thank you for your help !! Best regards --- Kuninori Morimoto
