On Wed, 2023-05-24 at 16:12 +0200, Alexandre Mergnat wrote: > On 23/05/2023 04:19, Trevor Wu wrote: > > There are two changes included in the patch. > > > > First, add set_dailink_daifmt() function, so dai_fmt can be updated > > by > > the configuration in dai-link sub node. > > > > Second, remove codec phandle from required property in dai-link sub > > node. > > For example, user possibly needs to update dai-format for all etdm > > co-clock dai-links, but codec doesn't need to be specified in > > capture > > dai-link for a speaker amp. > > > > Signed-off-by: Trevor Wu <trevor.wu@xxxxxxxxxxxx> > > --- > > .../mediatek/common/mtk-soundcard-driver.c | 49 > > ++++++++++++++++++- > > 1 file changed, 48 insertions(+), 1 deletion(-) > > > > diff --git a/sound/soc/mediatek/common/mtk-soundcard-driver.c > > b/sound/soc/mediatek/common/mtk-soundcard-driver.c > > index 738093451ccb..5e291092046b 100644 > > --- a/sound/soc/mediatek/common/mtk-soundcard-driver.c > > +++ b/sound/soc/mediatek/common/mtk-soundcard-driver.c > > @@ -22,7 +22,7 @@ static int set_card_codec_info(struct > > snd_soc_card *card, > > > > codec_node = of_get_child_by_name(sub_node, "codec"); > > if (!codec_node) > > - return -EINVAL; > > IMO, the debug or info print should be welcome here because the > behavior > change: dai link info parse will not stop if the codec node is NULL. > That could help to understand what is happening during init. > > > > Reviewed-by: Alexandre Mergnat <amergnat@xxxxxxxxxxxx> > Thanks for your suggestion. I will add a debug message here. Thanks, Trevor
