On 5/23/23 14:28, Mark Brown wrote: > On Tue, May 23, 2023 at 02:24:53PM -0500, Pierre-Louis Bossart wrote: > >> Wondering if this is the root cause of the regression we're seeing in >> [1] on a Chromebook with rt5682 in SoundWire mode? > >> I don't see any other changes to this codec driver and the first problem >> detected seemed to happen when we did an upstream merge last week. >> Unfortunately the last merge was on April 24 (sof-dev-rebase-20230424) >> which is just the day before this commit was added... > > Try a revert? I can try, unfortunately that device is not directly testable with a simple PR test so it'll take time. I was just hoping that someone smarter than me had an explanation on the locking issue. We only use interrupt threads and workqueues, not sure why sleeping is an issue.