alsa-project/alsa-utils pull request #215 was opened from wileyhy: This commit: - Added double quotes to common expansions; removed quotes from strings; - Changed REQUIRES to an indexed array and changed the corresponding for loop; - Added curly braces where feasibly necessary; - Removed a few unnecessary trailing semi-colons; - Put URL's in single quotes to prevent any possible expansions, except for within the sed command on line 988. - Some logic structures may depend on word splitting, on lines 641, 643, 654, and 667, so I left those as-is for this commit. - Double exclamation marks in double quotes allow history expansion which is usually disabled in non-interactive shells, so I left those as-is also. - Single quoted instances of 'yes' as a parameter value, since it's also a command name, which in certain contexts could be executed. - Removed quotes from instances of '$?' since it can only expand to an integer and cannot be unset. Some additional issues for consideration of further efforts (credit: shellcheck): - variables 'inp' on line 87 and 'KERNEL_RELEASE' on line 418 appear unused; - https://pastebin.ca is offline Request URL : https://github.com/alsa-project/alsa-utils/pull/215 Patch URL : https://github.com/alsa-project/alsa-utils/pull/215.patch Repository URL: https://github.com/alsa-project/alsa-utils
