On 5/18/2023 7:47 AM, Kuninori Morimoto wrote:
soc_get_playback_capture() (A) is handling both DPCM (X) / Normal (Y)
connection.
(A) static int soc_get_playback_capture(...)
{
...
^ if (dai_link->dynamic || dai_link->no_pcm) {
(X) ...
v
^ } else {
| ...
|(@) for_each_rtd_codec_dais(rtd, i, codec_dai) {
| if (dai_link->num_cpus == 1) {
|(a) cpu_dai = ...
(Y) } else if (dai_link->num_cpus == dai_link->num_codecs) {
|(b) cpu_dai = ...
| } else {
|(c) dev_err(...);
| }
| ...
| }
| ...
v }
...
}
In Normal connection case (Y), it is checking number of CPU / Codec.
(a) is for Single CPU case
(b) is for Multi CPU case
(c) is for other case (error)
Because this loop (@) is not related to dai_link->num_xxx,
we can judge (c) before entering this loop.
And it is needed not only for Normal connection case (Y),
but DPCM connection case (X) too.
This patch moves (c) to top side.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
---
Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@xxxxxxxxxxxxxxx>
