On 18/05/2023 04:37, Trevor Wu (吳文良) wrote: > On Wed, 2023-05-17 at 16:43 +0200, Krzysztof Kozlowski wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> On 17/05/2023 13:15, Trevor Wu wrote: >>> Add compatible string "mediatek,mt8188-nau8825" to support new >>> board >>> with nau8825 codec. >> >> Subject: everything can be update of properties. Rephrase to focus on >> actual change, e.g. on adding NAU8825. >> > OK. I will rename the topic in v2. > >>> >>> ADDA_BE is used to connect to mt6359. For the machine, it must be >>> fixed to the same codec and configured on the machine driver. >>> Remove >>> ADDA_BE from items of link-name. >> >> I don't understand the justification for this. If this is not a >> correct >> link name for MT6359 setup, then it should be removed in its own >> patch. >> If this is removed because of adding NAU8825, then why does it affect >> MT6359? >> > > In the patch series, [PATCH 1/5] divides ADDA_BE into UL_SRC_BE and > DL_SRC_BE. I was going to replace the link name, but I found it > shouldn't be configured for the machine, because mt6359 is the only > codec for ADDA_BE and it's hardcoded in the machine driver. As a > result, I decided to remove it. > > I will separate it from the patch, and put the new patch after [PATCH > 1/5]. Yes, please. Best regards, Krzysztof
