Il 17/05/23 14:10, Trevor Wu (吳文良) ha scritto:
On Wed, 2023-05-17 at 13:31 +0200, AngeloGioacchino Del Regno wrote:
External email : Please do not click links or open attachments until
you have verified the sender or the content.
Il 17/05/23 13:15, Trevor Wu ha scritto:
Some userspace applications need jack control events, so register
hdmi
and dp jack pins to activate jack control events.
Signed-off-by: Trevor Wu <trevor.wu@xxxxxxxxxxxx>
---
sound/soc/mediatek/mt8188/mt8188-mt6359.c | 27
+++++++++++++++++++----
1 file changed, 23 insertions(+), 4 deletions(-)
diff --git a/sound/soc/mediatek/mt8188/mt8188-mt6359.c
b/sound/soc/mediatek/mt8188/mt8188-mt6359.c
index 833bc362dad2..6c3f36e2fffd 100644
--- a/sound/soc/mediatek/mt8188/mt8188-mt6359.c
+++ b/sound/soc/mediatek/mt8188/mt8188-mt6359.c
@@ -151,6 +151,20 @@ struct mt8188_mt6359_priv {
struct snd_soc_jack hdmi_jack;
};
+static struct snd_soc_jack_pin mt8188_hdmi_jack_pins[] = {
+ {
+ .pin = "HDMI",
"HDMI Jack" is more consistent with the snd_soc_jack_new_pins() call
performed
later.
Hi Angelo,
I see jack_kctl_name_gen() will append "Jack" to the name if I don't
name the pin "HDMI Jack". Do you mean that I could directly use "HDMI
Jack" because ALSA uses the name finally?
You're right and I just checked; the comment even says
'remove redundant " Jack" from src_name'
So yes, the current names are fine. Sorry about that.
Regards,
Angelo
