-----Original Message----- From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Sent: Saturday, May 13, 2023 00:18 To: David.Rau.opensource <David.Rau.opensource@xxxxxxxxxxxxxx>; broonie@xxxxxxxxxx Cc: support.opensource@xxxxxxxxxxx; lgirdwood@xxxxxxxxx; perex@xxxxxxxx; tiwai@xxxxxxxx; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; conor+dt@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx Subject: Re: [PATCH] ASoC: da7219: Add Jack insertion detection polarity selection On 12/05/2023 10:10, David Rau wrote: > DA7219 can support 2 kinds of insertion detection polarity > - Default polarity (Low) > - Inverted polarity (High) > > This patch adds support for selecting insertion detection polarity to > the DT binding. > > Signed-off-by: David Rau <David.Rau.opensource@xxxxxxxxxxxxxx> > --- > .../devicetree/bindings/sound/da7219.txt | 3 ++ > Bindings are always separate patches. > Consider also converting them to DT schema first. Well noted and thanks for the kind suggestions. I will submit the binding change and driver code in different patch. > include/sound/da7219-aad.h | 6 ++++ > sound/soc/codecs/da7219-aad.c | 34 +++++++++++++++++++ > 3 files changed, 43 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/da7219.txt > b/Documentation/devicetree/bindings/sound/da7219.txt > index add1caf26ac2..357d1f61de1d 100644 > --- a/Documentation/devicetree/bindings/sound/da7219.txt > +++ b/Documentation/devicetree/bindings/sound/da7219.txt Best regards, Krzysztof
