On Mon, May 08, 2023 at 09:14:01AM +0200, Takashi Iwai wrote:
Must those be macros?
yes. at least with the additional checks i've added in v2.
Not only that macro isn't really safe to use for obvious reasons,
i don't see anything obviously bad. please be specific.
the expansion would cost significantly as they are called in many places.after i fixed the calls with a non-const register in v2, the code size increases by less than 400 bytes (with ~95 call sites). i'd say that's negligible.
regards
