Re: [PATCH] ALSA: pcm: fix snd_pcm_playback_silence() with free-running mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 4, 2023 at 9:08 PM Jaroslav Kysela <perex@xxxxxxxx> wrote:
>
> On 04. 05. 23 15:00, Oswald Buddenhagen wrote:
> > Turns out that we cannot rely on the application pointer being updated
> > in top-up mode, as its primary purpose is to remain operational in
> > free-running mode as used by dmix.
> >
> > So we logically revert some bits from commit 9f656705c5faa ("ALSA: pcm:
> > rewrite snd_pcm_playback_silence()"), but we retain the bug fixes and
> > try to make the code paths congruent.
>
> It would be better to revert the broken patch and make changes on top of the
> original code. This is really difficult to review.

Just to confirm that the patch works. Thanks!

Jeff




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux