Re: [PATCH v2 2/2] ASoC: dt-bindings: designware-i2s: add optional resets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/05/2023 09:16, Maxim Kochetkov wrote:
> Some SoC may have resets for I2S subsystem. So add optional resets support.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.  It might happen, that command when run on an older
kernel, gives you outdated entries.  Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least DT list (maybe more), so this won't be tested.
Please resend and include all necessary entries.

> 
> Signed-off-by: Maxim Kochetkov <fido_max@xxxxxxxx>
> ---
>  .../devicetree/bindings/sound/snps,designware-i2s.yaml         | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/snps,designware-i2s.yaml b/Documentation/devicetree/bindings/sound/snps,designware-i2s.yaml
> index 56e623d4e168..a970fd264b21 100644
> --- a/Documentation/devicetree/bindings/sound/snps,designware-i2s.yaml
> +++ b/Documentation/devicetree/bindings/sound/snps,designware-i2s.yaml
> @@ -36,7 +36,8 @@ properties:
>      const: i2sclk
>  
>    resets:
> -    maxItems: 1
> +    items:
> +      - description: Optional controller resets


This does not make much sense. Your change does nothing. NAK.

Best regards,
Krzysztof




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux