Re: [PATCH alsa-lib 2/4] pcm: hw: add drain_silence configuration keyword

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 03, 2023 at 04:22:03PM +0200, Jaroslav Kysela wrote:
On 03. 05. 23 13:24, Oswald Buddenhagen wrote:
what i could imagine _hypothetically_ making sense is making the 1/10th
sec "overshoot" configurable, as it's hardware-dependent. but in
practice, i don't see how that would be actually useful, as the cost of
doing too much is negligible, and the default you chose seems more than
safe enough.

The positive value is a bit bonus. I just picked an easy understandable way. But looking to this issue for the second time, I changed the meaning for the positive value to milliseconds. In this way, it's time/rate related.

i think it's a bad idea to add "bonus" features that have no clear use case. it's basically dead code, and you can't use these values for something actually useful later.

Thanks for the review of all patches - I picked some proposals and pushed changes to the alsa-lib repository:

well, and you ignored some of them for no obvious reason.

generally, i don't think maintainers should be exempt from replying to comments and posting v2+ patchsets.

regards



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux