On Mon, 24 Apr 2023 at 18:27, Conor Dooley <conor@xxxxxxxxxx> wrote: > On Mon, Apr 24, 2023 at 11:21:11AM +0800, Walker Chen wrote: > > > > > > On 2023/4/22 0:50, Conor Dooley wrote: > > > Hey Walker, > > > > > > On Thu, Apr 20, 2023 at 10:41:18AM +0800, Walker Chen wrote: > > >> Add the tdm controller node and sound card for the StarFive JH7110 SoC. > > > > > > Is this one of these waveshare things + a visionfive 2? > > > https://www.waveshare.com/wm8960-audio-hat.htm > > > > Hey Conor, > > I'm glad to receive your comments. > > > > Now we are using this board + VisionFive2 : > > https://wiki.seeedstudio.com/ReSpeaker_2_Mics_Pi_HAT/ > > > > > > > > I'm a bit lost as to why this needs a whole new board, should it not > > > just be an overlay that you can apply to the existing dts? > > > > > > Taking this to an extreme, should I expect to see a new devicetree for > > > everything RPi hat that you decide to use with a VisionFive 2? > > > > For your response, I did some thinking. Because wm8960 codec is not integrated > > on the VisionFive2 board, perhaps using overlay is a better way. > > Aye. I think so too. From my PoV, if this particular seeed audio board > is something you're bundling with VisionFive 2 boards on your storefront > etc, then I'm fine with taking it as an in-tree overlay. > If it is just a "random" RPi hat (that happens to be exactly what you > need for testing the audio drivers), then I don't know where to draw a > line for what is & what is not acceptable for inclusion. > > In both cases, it's Emil's call. I'm not aware of any shop bundling the VF2 with an audio board. I agree: please don't add device trees for combinations of VF2s and hats. That should be an overlay. /Emil > > > Also, it'd be nice to provide a Link: to where someone can find more > > > info on this combination of items. Google for "wm8960 visionfive 2" > > > gives me nothing, nor does "starfive audio card" etc. >
