--- Begin Message ---
- To: Rob Herring <robh@xxxxxxxxxx>
- Subject: Re: [PATCH 3/9] dt-bindings: ASoC: Add chv3-audio
- From: Paweł Anikiel <pan@xxxxxxxxxxxx>
- Date: Tue, 25 Apr 2023 18:01:47 +0200
- Cc: alsa-devel@xxxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, lgirdwood@xxxxxxxxx, broonie@xxxxxxxxxx, tiwai@xxxxxxxx, krzysztof.kozlowski+dt@xxxxxxxxxx, dinguyen@xxxxxxxxxx, lars@xxxxxxxxxx, nuno.sa@xxxxxxxxxx, upstream@xxxxxxxxxxxx
- In-reply-to: <20230417204150.GA3328603-robh@kernel.org>
- References: <20230414140203.707729-1-pan@semihalf.com> <20230414140203.707729-4-pan@semihalf.com> <20230417204150.GA3328603-robh@kernel.org>
On Mon, Apr 17, 2023 at 10:41 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Fri, Apr 14, 2023 at 04:01:57PM +0200, Paweł Anikiel wrote: > > Add binding for chv3-audio device. > > > > Signed-off-by: Paweł Anikiel <pan@xxxxxxxxxxxx> > > --- > > .../bindings/sound/google,chv3-audio.yaml | 49 +++++++++++++++++++ > > 1 file changed, 49 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/google,chv3-audio.yaml > > > > diff --git a/Documentation/devicetree/bindings/sound/google,chv3-audio.yaml b/Documentation/devicetree/bindings/sound/google,chv3-audio.yaml > > new file mode 100644 > > index 000000000000..8b602b60eaee > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/google,chv3-audio.yaml > > @@ -0,0 +1,49 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/sound/google,chv3-audio.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Google Chameleon v3 audio > > + > > +maintainers: > > + - Paweł Anikiel <pan@xxxxxxxxxxxx> > > + > > +properties: > > + compatible: > > + const: google,chv3-audio > > + > > + google,audio-cpu0: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: The phandle of controller #0 > > + > > + google,audio-codec0: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: The phandle of codec #0 > > + > > + google,audio-cpu1: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: The phandle of controller #1 > > + > > + google,audio-codec1: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: The phandle of codec #1 > > Why do you need custom properties when we have standard property to > point to these things (sound-dai). We also have bindings to handle > multiple devices. Thanks, I will read up on that and try to use it here Regards, Paweł
--- End Message ---
