On Fri, 28 Apr 2023 11:59:41 +0200, Oswald Buddenhagen wrote: > > The idea to encode the bitfield manipulation in the register address is > quite clever, but it's somewhat wasteful to do these calculations at > runtime, given that they are all constants. Change that. > > The added bitfield manipulation macros will be used separately as well. > > Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@xxxxxx> JFYI, I postpone applying this and the rest emu10k1 changes, since it's in a merge window now. They will be reviewed and merged for 6.5 after the 6.4 merge window. The patch "[PATCH RESEND] ALSA: emu10k1: use more existing defines instead of open-coded numbers" was already taken as it was a resent patch. So, if you have patches that fix bugs and should be applied soonish, submit those. thanks, Takashi
