On Wed, Apr 26, 2023 at 01:51:24PM +0800, Trevor Wu wrote: > Add apll1_d4 to clocks for switching the parent of top_a1sys_hp > dynamically. On the other hand, "mediatek,infracfg" is included for bus > protection. Bus protection? Meaning access controls for the device? If so, there's a proposed binding[1] for just that. If that's something Mediatek needs too, please participate in that discussion. It's easier to define new common bindings if there is more than one user. > > Signed-off-by: Trevor Wu <trevor.wu@xxxxxxxxxxxx> > --- > .../bindings/sound/mediatek,mt8188-afe.yaml | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8188-afe.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8188-afe.yaml > index 82ccb32f08f2..eb58de8c0e68 100644 > --- a/Documentation/devicetree/bindings/sound/mediatek,mt8188-afe.yaml > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8188-afe.yaml > @@ -29,6 +29,10 @@ properties: > $ref: /schemas/types.yaml#/definitions/phandle > description: The phandle of the mediatek topckgen controller > > + mediatek,infracfg: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of the mediatek infracfg controller > + > power-domains: > maxItems: 1 > > @@ -52,6 +56,7 @@ properties: > - description: mux for i2si1_mck > - description: mux for i2si2_mck > - description: audio 26m clock > + - description: audio pll1 divide 4 > > clock-names: > items: > @@ -73,6 +78,7 @@ properties: > - const: i2si1_m_sel > - const: i2si2_m_sel > - const: adsp_audio_26m > + - const: apll1_d4 A new required entry may break the ABI. If that's okay, it needs to be explained in the commit msg. Rob [1] https://lore.kernel.org/lkml/cover.1668070216.git.oleksii_moisieiev@xxxxxxxx/
