On Fri, 21 Apr 2023 19:26:23 +0200, Oswald Buddenhagen wrote: > > One might argue that this potentially breaks user space, but a) this is > just one driver among many, so it seems unlikely that someone would > expect (only) the broken codes and b) it seems unlikely that someone > would check these syscalls for particular errors at all, rather than > just logging them (this might be debatable for the voice allocator > calls). > > Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@xxxxxx> I find this is too risky for really little win. The error code is returned to user space in quite many cases; e.g. the voice allocator is called from PCM hw_params, too, and that's most of user-space programs do actually check. It could be a surprise if it's changed without much reason, may trigger unexpected behavior changes. Of course, if the error code must be corrected, we can fix it. But I don't see it in this patch description. thanks, Takashi
